Commit Graph
66 Commits
Author SHA1 Message Date
Sergey Ponomarev 65e9c6dff6 docker connector: refresh() delete container only if it not found but keep on failures
If inspect() call was failed due to connection problems then container will be removed anyway as like ot wasn't found.
This is probably almost never happens in real life but still some missed logic bug
2020-11-20 19:44:09 +02:00
Sergey Ponomarev df0d8b7892 #187 "created" action is handled separately in watchEvents() 2020-11-20 19:26:02 +02:00
Sergey Ponomarev ba126e6e7c events handling: early skipping of extremely frequent exec_* events
The exec_create, exec_start, exec_die and other events are generated by health checks
2020-11-18 23:04:29 +02:00
Sergey Ponomarev 009201ed0c actionToStatus: catch more generic die instead of kill 2020-11-18 23:04:29 +02:00
Sergey Ponomarev 4c280cee56 Improve docker events handling: separate channel for status updates
Instead of calling a heavy inspect api call we can easily changing status just by knowing an action.
Let's do this in a separate channel decouple UI update from basic event loop.
2020-11-17 22:00:03 +02:00
Sergey Ponomarev b65e970a83 Improve docker events handling
Firstly check health updates because it will be a lot of them especially when a container is unstable.
Clearly handle create event to create a container even if it wasn't started.
Instead of die event handle more precise events like oom, kill and only then trigger refresh.
Lookup the state from a map.
2020-11-17 21:50:25 +02:00
Sergey Ponomarev 957cabba2d docker.go: watchEvents() optimize actionName extraction
Split(e.Action, ":") creates and array but we can avoid this.
2020-11-17 12:06:34 +02:00
Sergey Ponomarev 5aacdc3772 docker.go: logging of events
Add log.IsEnabledFor(logging.DEBUG) guard to avoid unnecessary memory allocations. Debug level is usually disabled.
Inline "destroy"
2020-11-17 11:42:45 +02:00
Bradley Cicenas 99d9aeec98 set running = false when mock,runc collectors stopped 2020-11-13 21:43:11 +00:00
bradley 44600fca45 Merge pull request #201 from vcmkrtchyan/master
Fix freeze when container is started/stopped multiple times
2020-11-13 16:42:16 -05:00
Sergey Ponomarev 3a29c94833 Use percent() function to calc CPU usage 2020-11-13 11:02:14 +02:00
Bradley Cicenas c0703db094 add health check to mock connector 2020-10-26 12:02:31 +00:00
Bradley Cicenas 53ec5c911a return static error on unimplemented manager actions 2020-10-26 11:38:17 +00:00
Bradley Cicenas c5038e2edd aggregate io r/w across all reported stats volumes 2020-10-25 17:42:20 +00:00
Bradley Cicenas 03a0da3230 update go version, deps for runc v1.0.0-rc92 2020-10-25 14:22:47 +00:00
Vahe Mkrtchyan 4a0e80ffdf Fix freeze when container is started/stopped multiple times 2020-07-23 15:23:19 +04:00
Bradley Cicenas 4b391e900c use raw log stream in docker log collector 2019-11-06 07:32:29 -05:00
Bradley Cicenas 0a5a4c9062 add multi-line scrolling support, timestamps to error view 2019-05-22 17:38:01 +00:00
Bradley Cicenas 98fcfe8b6f refactor connectors for retry logic, add error view 2019-05-22 16:58:55 +00:00
Bradley Cicenas c1d4615cc0 Merge branch 'fr05t1k-exec' 2019-05-12 16:26:51 -04:00
Bradley Cicenas d187e8c623 drop potentially empty initial frames during exec attach 2019-05-12 20:23:54 +00:00
Bradley Cicenas d7384db373 Merge branch 'exec' of https://github.com/fr05t1k/ctop into fr05t1k-exec 2019-05-12 15:31:33 -04:00
CodeLingo Bot b401e7b17e Fix function comments based on best practices from Effective Go
Signed-off-by: CodeLingo Bot <bot@codelingo.io>
2019-03-07 02:33:29 +00:00
Stanislav Pavlovichev 101ddad692 Fixed a problem with rendering 2018-10-28 13:43:24 +02:00
Stanislav Pavlovichev d59c91a461 Do not allow to close /dev/stdin 2018-10-26 17:08:33 +03:00
bartfokker 8a0bd3cf8a remove unneeded cast 2018-10-25 22:22:28 +02:00
bartfokker 4d247f5272 replace unkeyed fiels with keyed fields when instantiating log struct 2018-10-25 22:17:05 +02:00
bartfokker 4d48245d7d improve boolean logic 2018-10-25 22:12:17 +02:00
bartfokker 6bee1b7f31 remove unneeded select for simple channel receive 2018-10-25 22:11:17 +02:00
Stanislav Pavlovichev 967a87a65f Exec using API 2018-10-13 08:33:53 +03:00
Serhii Bilonozhko 9a185b2388 env-var 2018-10-05 17:35:22 -04:00
Jean-Philippe a72d43526f add IP of networks in single view mode 2018-09-06 21:01:16 +02:00
xiechengsheng f7a3d38d6b add more commands in container manager menu
Signed-off-by: xiechengsheng <XIE1995@whut.edu.cn>
2018-06-22 15:41:16 +08:00
Bradley Cicenas 10b9a6c013 include windows build 2018-01-31 17:05:54 +00:00
Bradley Cicenas a3b67e4607 add available connectors to help dialog 2018-01-30 07:54:13 -03:00
Bradley Cicenas ac1ce18143 refactor enabled connectors 2018-01-29 12:47:10 +00:00
Bradley Cicenas d785b263f4 add scale-cpu switch 2018-01-11 12:19:00 -03:00
Bradley Cicenas 1c8f4b3a35 add logging for log reader start/stop 2017-11-28 09:38:32 -05:00
Bradley Cicenas 3e5176a79c add NewDockerLogs constructor method 2017-11-28 09:36:28 -05:00
Bradley Cicenas a826859202 gofmt 2017-11-22 09:27:38 -05:00
Bradley Cicenas 71b4a1de94 add runc manager placeholder 2017-11-22 09:26:01 -05:00
Peter Reisinger 436266b1a4 added container menu closes #28 2017-11-20 11:09:36 +00:00
Bradley Cicenas a1ebf3f90e remove duplicate inspect, trigger refresh on "health_status" events 2017-08-28 08:29:59 +09:00
Alexandr Kozlenkov 626d50d3e9 Added health row to Info Single mode.
Change color status logic.

Highlight health status for Name column:
- starting - yellow
- healthy - green
- unhealthy - magenta

reformat

Fixed misprint

Removed unused colors of state widget.

Moved changes to another branch

Removed unused colors of state widget.

Remove swarm changes from master

Remove swarm changes from master

Remove swarm changes from master
2017-08-28 07:55:43 +09:00
Bradley Cicenas 55a356bbec omit cache from memory usage stat 2017-08-11 16:44:52 +02:00
Bradley Cicenas 79a3f361a7 add container log struct to models, collectors 2017-07-04 12:32:25 +00:00
Bradley Cicenas 17e2c2df8e add LogCollector interface, docker, mock log collectors 2017-06-27 14:18:17 -03:00
Bradley Cicenas 240345d527 add StreamLogs() to collector interface 2017-06-26 15:35:57 +00:00
Bradley Cicenas 2d284d9277 rename metrics subpackage 2017-06-26 15:35:57 +00:00
Bradley Cicenas 58d9e4e194 reverse host and container port in metadata 2017-06-18 17:17:56 -03:00