ahp/busybox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rmmod: fix bad error message

Browse source 
Before:

    ># busybox_old rmmod gtrhfhdfghdf
    rmmod: can't unload 'gtrhfhdfghdf': unknown symbol in module, or unknown parameter

    After:

    ># busybox rmmod gtrhfhdfghdf
    rmmod: can't unload module 'gtrhfhdfghdf': No such file or directory

function                                             old     new   delta
modprobe_main                                        726     721      -5
do_modprobe                                          599     590      -9
rmmod_main                                           187     169     -18
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-32)             Total: -32 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2015-10-24 04:17:04 +02:00
parent 2e9a0662bc
commit cd13974b20
3 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modutils/modutils.c
View file

@ -190,6 +190,11 @@ int FAST_FUNC bb_delete_module(const char *module, unsigned int flags)
return errno;
}
/* Note: not suitable for delete_module() errnos.
* For them, probably only EWOULDBLOCK needs explaining:
* "Other modules depend on us". So far we don't do such
* translation and don't use moderror() for removal errors.
*/
const char* FAST_FUNC moderror(int err)
{
switch (err) {